On 31/10/2011 23:05, Konstantin Kolinko wrote:
> 2011/11/1 Mark Thomas <ma...@apache.org>:
>>>>>
>>>>> +import org.apache.catalina.util.Enumerator;
>>>>
>>>> -1
>>>>
>>>> That import is not permitted. The o.a.tomcat package may not depend on
>>>> o.a.catalina. You should have seen a checkstyle warning for that when
>>>> you tried to build it.
>>>>
>>>
>>> Maybe move that Enumerator class into org.apache.tomcat.util.collections ?
>>> (Resurrecting the collections package)
>>
>> That works for trunk. It would need to be a copy + deprecation for 7.0.x.
>>
>>> There are two copies of Enumerator class now: one in catalina and one in 
>>> jasper.
>> Jasper will need to keep its own copy as it can't have any external
>> dependencies.
> 
> Isn't tomcat-util.jar the place for classes that both Catalina and
> Jasper depend on?

Ah yes, I forgot we added that for the Jar scanning stuff. I don't see
any reason not to include Enumeration in that jar.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to