Author: kkolinko
Date: Wed Oct 26 21:27:24 2011
New Revision: 1189477
URL: http://svn.apache.org/viewvc?rev=1189477&view=rev
Log:
Followup to r1189256
Correct typo in i18n message: RemoteIpValve is a different beast
Add Javadoc for new fields in RequestFilterValve
Modified:
tomcat/trunk/java/org/apache/catalina/valves/LocalStrings.properties
tomcat/trunk/java/org/apache/catalina/valves/RequestFilterValve.java
Modified: tomcat/trunk/java/org/apache/catalina/valves/LocalStrings.properties
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/valves/LocalStrings.properties?rev=1189477&r1=1189476&r2=1189477&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/valves/LocalStrings.properties
(original)
+++ tomcat/trunk/java/org/apache/catalina/valves/LocalStrings.properties Wed
Oct 26 21:27:24 2011
@@ -40,7 +40,8 @@ errorReportValve.rootCauseInLogs=The ful
# Remote IP valve
remoteIpValve.invalidPortHeader=Invalid value [{0}] found for port in HTTP
header [{1}]
-requestFilterValve.configInvalid=One or more invalid configuration settings
were provided for the Remote[Host|Ip]Valve which prevented the Valve and its
parent containers from starting
+# Request filter valve - RemoteAddrValve, RemoteHostValve
+requestFilterValve.configInvalid=One or more invalid configuration settings
were provided for the Remote[Addr|Host]Valve which prevented the Valve and its
parent containers from starting
sslValve.certError=Failed to process certificate string [{0}] to create a
java.security.cert.X509Certificate object
sslValve.invalidProvider=The SSL provider specified on the connector
associated with this request of [{0}] is invalid. The certificate data could
not be processed.
Modified: tomcat/trunk/java/org/apache/catalina/valves/RequestFilterValve.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/valves/RequestFilterValve.java?rev=1189477&r1=1189476&r2=1189477&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/valves/RequestFilterValve.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/valves/RequestFilterValve.java Wed
Oct 26 21:27:24 2011
@@ -72,6 +72,13 @@ public abstract class RequestFilterValve
* The regular expression used to test for allowed requests.
*/
protected volatile Pattern allow = null;
+
+ /**
+ * Helper variable to catch configuration errors.
+ * It is <code>true</code> by default, but becomes <code>false</code>
+ * if there was an attempt to assign an invalid value to the
+ * <code>allow</code> pattern.
+ */
protected volatile boolean allowValid = true;
@@ -79,6 +86,13 @@ public abstract class RequestFilterValve
* The regular expression used to test for denied requests.
*/
protected volatile Pattern deny = null;
+
+ /**
+ * Helper variable to catch configuration errors.
+ * It is <code>true</code> by default, but becomes <code>false</code>
+ * if there was an attempt to assign an invalid value to the
+ * <code>deny</code> pattern.
+ */
protected volatile boolean denyValid = true;
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
