On 26/10/2011 20:07, Francis Galiegue wrote: > Hello, > > It has been now three weeks since I opened this enhancement request: > > https://issues.apache.org/bugzilla/show_bug.cgi?id=51953 > > I am confident enough with this patch that I actually use it instead > of the existing RemoteAddrValve (since my implementation doesn't get > confused by ::1 just to cite an example), but it has now been ten days > and I haven't had a single comment on things to improve etc. How are > enhancement requests reviewed?
Requests are reviewed as committers have the time and interest in the features being implemented. Your own comments on that bug seem to indicate that the patch has issues with logging and exception handling. As soon as I saw that, the issue went to the bottom of my todo list until the issues were fixed (or at least understood). You may also want to look at my commit from earlier today regarding handling of errors in security concious filters and valves. > How long does it normally take for such > a request to be considered for inclusion? Anywhere from less than an hour to several years. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org