On 09/10/2011 15:08, Olivier Lamy wrote:
> Hello,
> I'd like to be able to use a random port when using embedded Tomcat in
> unit tests to test servlets.
> Currently it's "locked" by a test in Connector#startInternal.
> Is it intentional ?
svn blame would have answered that for you.
> I'd like to be able to do simply something like :
>
> Tomcat tomcat = new Tomcat();
> tomcat.setBaseDir(System.getProperty("java.io.tmpdir"));
> tomcat.getConnector().setPort( 0 );
If you want a random port, why not just set a random port at this point?
> Makes sense for to add getLocalPort on Connector class and remove the
> test if (getPort() < 1) ?
No.
> If yes I can start on providing a patch for review.
I'd be against adding that patch to the code base.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
