2011/9/20 Rainer Jung <[email protected]>: > > Thanks for the review. > > I refactored trunk a bit to move some of the common clone code to the > base class. If you like it I will backport to TC 7. Please comment on > r1173088 and r1173090. > > Regards, > > Rainer >
That looks nice except for the following. I added two fixes. maxActiveSessions is removed from BackupManager#cloneFromTemplate. The copy of maxActiveSessions is already done by ClusterManagerBase#clone. For creating the instance of sessionAttributePattern, we have to call setter of sessionAttributeFilter. I committed them on r1173461. Please check it. -- Keiichi.Fujino --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
