https://issues.apache.org/bugzilla/show_bug.cgi?id=50504
--- Comment #2 from Christopher Schultz <ch...@christopherschultz.net> 2011-09-20 21:50:03 UTC --- Couldn't this just be written as a Valve? The only utility I can see for checking for a request attribute like "org.apache.tomcat.request.query_encoding" would be to have /another/ Valve set that value conditionally (or even unconditionally) for some reason. If you're writing a Valve, why not just go ahead and set the character encoding yourself at that point? I briefly considered a Valve that inspected a request /parameter/ to see if the client wanted to specify that everything was to be decoded in, say, shift-jis or something, but that gets you into a chicken-in-an-egg scenario so it's not a valid use case. I don't see why the Request class should be modified in this way when a Valve can accomplish the same thing. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
