On 07/09/2011 13:51, sebb wrote: > On 7 September 2011 13:31, <ma...@apache.org> wrote: >> Author: markt >> Date: Wed Sep 7 12:31:30 2011 >> New Revision: 1166150 >> >> URL: http://svn.apache.org/viewvc?rev=1166150&view=rev >> Log: >> async more likely than comet >> >> Modified: >> tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java >> >> Modified: >> tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java >> URL: >> http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java?rev=1166150&r1=1166149&r2=1166150&view=diff >> ============================================================================== >> --- tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java >> (original) >> +++ tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java >> Wed Sep 7 12:31:30 2011 >> @@ -1028,7 +1028,7 @@ public abstract class AbstractHttp11Proc >> >> if (error || endpoint.isPaused()) { >> return SocketState.CLOSED; >> - } else if (comet || isAsync()) { >> + } else if (isAsync() || comet) { > > But surely it's very cheap to check comet?
Yep. The benefit, if any, is minimal. It can about as much from aligning the connectors. Mark > BTW, there is another conditional in the same class that checks comet > before Asynch. > > 883 while (!error && keepAlive && !comet && !isAsync() && > >> return SocketState.LONG; >> } else { >> if (sendfileInProgress) { >> >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >> For additional commands, e-mail: dev-h...@tomcat.apache.org >> >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org