Author: kkolinko Date: Thu Aug 25 16:58:03 2011 New Revision: 1161638 URL: http://svn.apache.org/viewvc?rev=1161638&view=rev Log: vote
Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1161638&r1=1161637&r2=1161638&view=diff ============================================================================== --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Thu Aug 25 16:58:03 2011 @@ -88,7 +88,8 @@ PATCHES PROPOSED TO BACKPORT: Display error page rather than an empty response for an IllegalStateException https://issues.apache.org/bugzilla/attachment.cgi?id=27318 +1: markt - -1: + -1: kkolinko: Same concerns as in 5.5. At least it should + catch(Throwable) in JkCoyoteHandler. * Fix two typos in tomcat.nsi (uppercase vs. lowercase in a macro call and in a message) Already fixed in 5.5, 7.0, trunk. @@ -100,9 +101,15 @@ PATCHES PROPOSED TO BACKPORT: found http://people.apache.org/~markt/patches/2011-08-25-ajp-incomplete-msg-tc6.patch +1: markt + +1: kkolinko: + Need to s/"" + pos/String.valueOf(posToTest)/ in AjpMessage#validatePos() + - wrong variable is used. + +1 to annotate AjpMessage#getBytes(byte[]) as @Deprecated - it is + never used, so cannot say whether consuming terminating '\0' is + needed like in #doGetBytes(). -1: * Update Eclipse compiler and Tomcat native http://people.apache.org/~markt/patches/2011-08-25-lib-update-tc6.patch - +1: markt + +1: markt, kkolinko -1: --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org