On 14.07.2011 11:21, Mark Thomas wrote: > The proposed Apache Tomcat 7.0.19 release is now available for voting. > > It can be obtained from: > http://people.apache.org/~markt/dev/tomcat-7/v7.0.19/ > The svn tag is: > http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_19/ > > The proposed 7.0.19 release is: > > [ ] Broken - do not release > [ ] Alpha - go ahead and release as 7.0.19 Alpha > [ ] Beta - go ahead and release as 7.0.19 Beta > [X] Stable - go ahead and release as 7.0.19 Stable
+1 to release as stable, looks good to me. The 400 access log entries seem to be gone for all three ajp connectors. AJP connection persistance is fine for BIO and APR. The experimental NIO seems to still not use persistent AJP connections, but is IMHO no show stopper, because it is new and marked as experimental in the docs. One somewhat strange observation: JMX shows additional open files after the request to the JMXProxy. Looking at it I find the file .../jre/lib/charsets.jar opened twice! It uses two file descriptors. I guess the addition of it is due to retrieving the available charsets to fill the charset cache. But I have no idea, why it is open twice. Note: it is not open directly after restart, not even once, but after I had hit the jmxproxy it was open twice and never closed again. The number didn't increase after additional requests for the same or other contexts. Not a real problem, more a curiosity. - MD5 OK - signatures OK - key in KEYS file - gz and zip for src and bin consistent Except for 3 missing svn:eol-style in jdbc-pool, which I added now. - src consistent with svn tag Except for the following minor points: - The files we copy before building, e.g. catalina.properties and jdbc-pool.xml are of course not in svn for the cp target location, but they are there in the src bundles. - File modules/jdbc-pool/sign.sh is in svn but not part of the gz or zip sources - builds fine - build result looks consistent with binaries - no checkstyle complaints - no Javadoc errors - Unit tests run OK for BIO, NIO and APR No single test failure :) - JMX MBean-Comparison OK - TLD scanning a bit faster, I guess due to improved jarsToSkip. - thread names in MBean attributes now without strange quotes, but MBean names unchanged. - 3 more File descriptors open, jdbc-pool jar plus the two charset jars noted above Build and tests were done using Java 1.6.0_24, OS was Solaris 10 Sparc, tcnative was 1.1.20 based on APR 1.4.5 and OpenSSL 0.9.8r. Looks pretty good! Regards, Rainer --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org