Konstantin,
1. One should really ask system administrators what they prefer
What would be the right place to do that? User list, maybe? I assume at least some of Tomcat developers are also involved in system administration, so I hope they will state their opinion here.
(or provide a configuration option).
That is also possibility. What would be good place to configure: 1. AccessLogValve XML parameter? 2. AccessLogValve system property (-D...) 3. Global Tomcat XML parameter? 4. Global Tomcat system property?
Personally I would prefer the full address, as I think it is easier when all is data is visible, and it is easier to search or filter.
I thought that at first, but after looking IPv6 addresses in log files for some time, I changed my mind. Shorter means easier to read, and easier to search... if there are no ambiguities.
If there are several sequences of zeros, only one of them can be collapsed. This introduces ambiguity when trying to specify a search filter.
Actually, mentioned RFC resolves all ambiguities: ==== When there is an alternative choice in the placement of a "::", the longest run of consecutive 16-bit 0 fields MUST be shortened (i.e., the sequence with three consecutive zero fields is shortened in 2001: 0:0:1:0:0:0:1). When the length of the consecutive 16-bit 0 fields are equal (i.e., 2001:db8:0:0:1:0:0:1), the first sequence of zero bits MUST be shortened. For example, 2001:db8::1:0:0:1 is correct representation. ----
2. If you want to contribute, please create a bugzilla entry, mark it as an enhancement.
Ok, I created: https://issues.apache.org/bugzilla/show_bug.cgi?id=51497
The class may go into org.apache.tomcat.util.net. I would prefer to see some JUnit tests together with the class.
Of course, I have JUnit for all the examples in the RFC.
3. Regarding Apache Commons: you can ask on their mailing lists.
...
As thus, your contribution to Tomcat can be independent from Commons.
Ok, let's see first if it works for Tomcat. -Ognjen --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
