On 10/07/2011 14:53, Rainer Jung wrote: > Using an AccessLogValve during the unit tests reveals, that the thread > name in the request processor is often not set when handliung async > requests. > > To reproduce run TestAsyncContextImpl for trunk with test.accesslog=true > and have a look at the access log in output/build/logs. The only > requests logged wit a thread name are > > 127.0.0.1 - - [10/Jul/2011:15:..:.. +0200] "GET /error HTTP/1.1" 500 > 1332 http-bio-8030-exec-1 8 > 127.0.0.1 - - [10/Jul/2011:15:..:.. +0200] "GET /error HTTP/1.1" 500 > 1332 http-nio-8030-exec-1 9 > 127.0.0.1 - - [10/Jul/2011:15:..:.. +0200] "GET /error HTTP/1.1" 500 > 1332 http-apr-8030-exec-2 8 > > All other requests have "null" as the thread name. > > The following patch fixes most of the cases, but I'm not sure that it is > the right place to fix it: > > http://people.apache.org/~rjung/patches/tomcat-async-threadname.patch
Looks good to me. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
