On 08.07.2011 10:50, Mark Thomas wrote:
> On 08/07/2011 09:47, Rainer Jung wrote:
>> No without wild guessing:
>>
>> AjpProcessor.recycle() now nulls input. On the next loop through
>> processing the connection, trying to read from the nulled input will
>> lead to an NPE, producing the 400 log entry.
>>
>> In 7.0.16 recycle was implemented in AbstractAjpProcessor.java and did
>> not null input.
>
> Looks like another refactoring problem. I'll take a look.
Index: java/org/apache/coyote/ajp/AjpProcessor.java
===================================================================
@@ -242,13 +242,6 @@
}
- @Override
- public void recycle() {
- super.recycle();
- input = null;
- output = null;
- }
-
// ----------------------------------------------------- ActionHook
Methods
might do it. recycle() is only called once and at that place we don't
want to null input (and output) except we break out from the loop.
Directly below the loop we null input and output, except when we still
need it. At least my interpretation of the code.
The change fixes the issue, but I didn't extensively test it.
Regards,
Rainer
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
