On 13.06.2011 17:49, Mark Thomas wrote:
> On 13/06/2011 16:07, Rainer Jung wrote:
>> I had some spare time for analyzing the crashes in
>> TestMapperWelcomeFiles. It seems there are several varieties, but at
>> least I do now understand enough to report here:
>>
...

>> This seems to be a flaw. I suggest we add only to the poller if we know
>> no error occured and the endpoint is not paused. The patch for AjpApr is
>> simpler but similar. See for both classes:
>>
>> http://people.apache.org/~rjung/patches/tc7-apr-add_to_poller.patch
>>
>> I checked this patch against one full run of the test suite with HTTP
>> APR and also against 150 runs of TestMapperWelcomeFiles. No crashes or
>> errors any more.
>>
>> WDYT?
> 
> Analysis and patch make sense to me.

Thanks for reviewing. After about 900 test iterations I committed in
r1135208.

Regards,

Rainer

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to