On 06/06/2011 18:43, Caldarale, Charles R wrote: >> From: Mark Thomas [mailto:ma...@apache.org] >> Subject: Re: svn commit: r1132367 - in /tomcat/trunk: >> java/org/apache/coyote/http11/Http11AprProcessor.java >> webapps/docs/changelog.xml > >> On 06/06/2011 09:01, Remy Maucherat wrote: >>> I don't understand, the code reads: >>> sendfileData = new AprEndpoint.SendfileData(); >>> sendfileData.fileName = fileName; >>> sendfileData.start = ((Long) request.getAttribute( >>> "org.apache.tomcat.sendfile.start")).longValue(); >>> sendfileData.end = ((Long) request.getAttribute( >>> "org.apache.tomcat.sendfile.end")).longValue() - sendfileData.pos; >>> >>> So how can sendfileData.pos not be 0 here ? > >> Because when the DefaultServlet handles a range request start may be >> non-zero. (line 1658 in trunk) > > That's not the issue; the question is how could sendFileData.pos be non-zero > in an object that was just instantiated from a class that has no explicit > constructor?
Doh. Got it. We do need to modify the length to handle range requests, but not like that. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
