https://issues.apache.org/bugzilla/show_bug.cgi?id=51212
Bug #: 51212 Summary: QueryStats has synchornisation issues Product: Tomcat Modules Version: unspecified Platform: All Status: NEW Severity: major Priority: P2 Component: jdbc-pool AssignedTo: dev@tomcat.apache.org ReportedBy: p.moua...@ubik-ingenierie.com Classification: Unclassified Created attachment 27017 --> https://issues.apache.org/bugzilla/attachment.cgi?id=27017 Patch with Atomic approach Hello, I don't know if it is volontary but I think QueryStats fields should be Atomic because they are accessed by multiple threads at same time. I made a Load test with heavy load and collected results of SlowQueryReport and I get Sql queries with 0 as number of executions which is wrong as they have been executed at least once. By the way I don't know which approach will perform better: - synchronize add/failure - Use Atomic Maybe you did this for performance reasons. Regards Philippe Mouawad http://www.ubik-ingenierie.com -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org