On 04/05/2011 16:17, Filip Hanik - Dev Lists wrote: > Here is what I propose, and you'll see that it's pretty much inline with > what you suggest. > > a) add in a flag that lets keep alive be turned off during concurrency > disableKeepAlivePercentage="75" > this would be the default value. and would achieve exactly what you want > in your a) > >> a) restore disabling keep-alive when threads used>= 75% of maxThreads > >> b) remove maxConnections and associated code from the APR connector > b) > or you can simply make pollerSize==maxConnections > meaning that > setPollerSize(5000) is the same as setMaxConnections(5000) > that way you retain the same properties across connectors > >> c) remove the configuration options for maxConnections from the BIO >> connector > I think you still misunderstand why maxConnections is there, at some > point you need to push back on the TCP stack. > and still be able to control when to accept new connections. > Keep this setting in there, exactly as it is. > >> d) use maxThreads instead of maxConnections for the BIO connector > if you feel so strongly on this, simple set maxConnections=200 as the > default value for BIO connector.
All now implemented in trunk. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
