Author: kkolinko
Date: Sun Apr 10 16:23:27 2011
New Revision: 1090826
URL: http://svn.apache.org/viewvc?rev=1090826&view=rev
Log:
vote
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1090826&r1=1090825&r2=1090826&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Sun Apr 10 16:23:27 2011
@@ -202,5 +202,13 @@ PATCHES PROPOSED TO BACKPORT:
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=36362
Check that tag file attribute names use valid Java identifiers
http://svn.apache.org/viewvc?rev=1090766&view=rev
- +1: markt
+ +1: markt, kkolinko
-1:
+ kkolinko: 1) Message key "jsp.error.identifier" is too broad while the
+ message says about attributes only. What about <%@variable%> directives,
+ if we would implement the same check for their name-given or alias?
+ 2) By the way, one more restriction in JSP.11.1.1.1: "The JSP
+ specification reserves names for methods and variables starting with
+ jsp, _jsp, jspx, and _jspx, in any combination of upper and lower case."
+ 3) I am OK with enabling this specific check unconditionally, because I
+ think it is already enforced when compiling a tag file.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
