On 31/03/2011 12:25, Keiichi Fujino wrote: > By this rev I think that /META-INF/context.xml is added to > redeployResources when copyXML is false.
That was indeed the intention. > Then, there is two question. > > Q1. > After deploying war, > the order of redeployResources becomes war -> directory -> > /META-INF/context.xml. So far, so good. > When /META-INF/context.xml is updated, the context is redeployed. > Then, because /META-INF/context.xml already exists in the directory, > the order of redeployResources becomes war -> /META-INF/context.xml -> > directory. I smell trouble ahead. > The next resource of the updated resource is deleted in > HostConfig#checkResources. > Therefore, when /META-INF/context.xml is updated again, the directory > is deleted. > However /META-INF/context.xml exists in the deleted directory. > > As a result, because updated /META-INF/context.xml is deleted, it > might not be intended work. Yep. Trouble. That isn't good at all. Thanks for the review. I had missed that. I'll revisit it. > Q2. > Is the addition of /META-INF/context.xml only deployment of the war? > Need it for deployment of the directory? I think the answer is yes. The intention is that the redeployment order is always: war -> directory -> /META-INF/context.xml Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
