Would it be more "efficient" to do this instead?
- /** Node identifier when in a cluster. Defaults to the empty string. */
- private String jvmRoute = "";
+ /** Node identifier when in a cluster. */
+ private String jvmRoute = null;
...
public void setJvmRoute(String jvmRoute) {
if (jvmRoute!=null&&jvmRoute.length()==0) {
jvmRoute=null;
}
this.jvmRoute = jvmRoute;
}
-Tim
On 3/30/2011 7:09 PM, ma...@apache.org wrote:
Author: markt
Date: Wed Mar 30 23:09:10 2011
New Revision: 1087128
URL: http://svn.apache.org/viewvc?rev=1087128&view=rev
Log:
Don't append the jvmRoute to a session ID if the jvmRoute is a zero length
string.
Modified:
tomcat/trunk/java/org/apache/catalina/util/SessionIdGenerator.java
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trunk/java/org/apache/catalina/util/SessionIdGenerator.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/util/SessionIdGenerator.java?rev=1087128&r1=1087127&r2=1087128&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/util/SessionIdGenerator.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/util/SessionIdGenerator.java Wed Mar
30 23:09:10 2011
@@ -168,7 +168,7 @@ public class SessionIdGenerator {
}
}
- if (jvmRoute != null) {
+ if (jvmRoute != null&& jvmRoute.length()> 0) {
buffer.append('.').append(jvmRoute);
}
Modified: tomcat/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1087128&r1=1087127&r2=1087128&view=diff
==============================================================================
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Wed Mar 30 23:09:10 2011
@@ -128,6 +128,10 @@
name ending in<code>.jar</code> to be treated as an expanded JAR file
by the default JarScanner. Based on patch by Rodion Zhitomirsky.
(markt)
</fix>
+<fix>
+ Don't append the jvmRoute to a session ID if the jvmRoute is a
zero
+ length string. (markt)
+</fix>
</changelog>
</subsection>
<subsection name="Coyote">
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
