2011/3/7 <ma...@apache.org>: > Author: markt > Date: Sun Mar 6 22:02:28 2011 > New Revision: 1078595 > > URL: http://svn.apache.org/viewvc?rev=1078595&view=rev > Log: > Clean-up, mainly unused code > > Modified: > > tomcat/trunk/java/org/apache/naming/resources/DirContextURLStreamHandler.java >
Apparently it was the alternative method to configure protocol handler for the jndi: URLs, instead of using a custom URLStreamHandlerFactory implementation, as documented in JavaDoc for constructors of java.net.URL. [1] It worked together with the following class (already removed from Tomcat 7, but present in 6.0): org.apache.naming.resources.jndi.Handler (removed in http://svn.apache.org/viewvc?rev=1078798&view=rev ) The current method that Tomcat uses is to call static method URL.setURLStreamHandlerFactory( ) which is done in WebappLoader.startInternal(). I think that I do not mind removing this feature from Tomcat 7, but I wonder whether it were useful in some embedded scenarios, where container app has its own system-wide URLStreamHandlerFactory. Removal of the below code is not crucial for such a use case (as the app can update the system property by itself), but removal of the Handler class is crucial. [1] http://download.oracle.com/javase/1.4.2/docs/api/java/net/URL.html#URL%28java.lang.String,%20java.lang.String,%20int,%20java.lang.String%29 [2] http://download.oracle.com/javase/6/docs/api/java/net/URL.html#URL%28java.lang.String,%20java.lang.String,%20int,%20java.lang.String%29 Best regards, Konstantin Kolinko > Modified: > tomcat/trunk/java/org/apache/naming/resources/DirContextURLStreamHandler.java > URL: > http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/naming/resources/DirContextURLStreamHandler.java?rev=1078595&r1=1078594&r2=1078595&view=diff > ============================================================================== > --- > tomcat/trunk/java/org/apache/naming/resources/DirContextURLStreamHandler.java > (original) > +++ > tomcat/trunk/java/org/apache/naming/resources/DirContextURLStreamHandler.java > Sun Mar 6 22:02:28 2011 > @@ -31,8 +31,7 @@ import javax.naming.directory.DirContext > * @author <a href="mailto:r...@apache.org";>Remy Maucherat</a> > * @version $Revision$ > */ > -public class DirContextURLStreamHandler > - extends URLStreamHandler { > +public class DirContextURLStreamHandler extends URLStreamHandler { > > > // ----------------------------------------------------------- > Constructors > @@ -134,21 +133,6 @@ public class DirContextURLStreamHandler > > > /** > - * Set the java.protocol.handler.pkgs system property. > - */ > - public static void setProtocolHandler() { > - String value = > System.getProperty(Constants.PROTOCOL_HANDLER_VARIABLE); > - if (value == null) { > - value = Constants.Package; > - System.setProperty(Constants.PROTOCOL_HANDLER_VARIABLE, value); > - } else if (value.indexOf(Constants.Package) == -1) { > - value += "|" + Constants.Package; > - System.setProperty(Constants.PROTOCOL_HANDLER_VARIABLE, value); > - } > - } > - > - > - /** > * Returns true if the thread or the context class loader of the current > * thread is bound. > */ > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
