On 14/02/2011 06:53, Felix Schumacher wrote: > > > ma...@apache.org schrieb: > >> Author: markt >> Date: Fri Feb 11 14:49:41 2011 >> New Revision: 1069824 >> >> URL: http://svn.apache.org/viewvc?rev=1069824&view=rev >> Log: >> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50751 >> Don't try to retrieve attributes if we don't need to. If anonymous bind >> is not allowed, the login will always fail. >> >> Modified: >> tomcat/trunk/java/org/apache/catalina/realm/JNDIRealm.java >> tomcat/trunk/webapps/docs/changelog.xml >> >> Modified: tomcat/trunk/java/org/apache/catalina/realm/JNDIRealm.java >> URL: >> http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/realm/JNDIRealm.java?rev=1069824&r1=1069823&r2=1069824&view=diff >> ============================================================================== >> --- tomcat/trunk/java/org/apache/catalina/realm/JNDIRealm.java >> (original) >> +++ tomcat/trunk/java/org/apache/catalina/realm/JNDIRealm.java Fri Feb >> 11 14:49:41 2011 >> @@ -1245,6 +1245,11 @@ public class JNDIRealm extends RealmBase >> String dn) >> throws NamingException { >> >> + // If no attributes are requested, no need to look for them >> + if (attrIds == null || attrIds.length > 0) { > Shouldn't this be attrIds.length == 0?
Yep. Good catch. I clearly didn't have my brain in gear when I wrote that. Fixing it now... Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
