2011/2/6 Mark Thomas <ma...@apache.org>:
> On 06/02/2011 20:45, Konstantin Kolinko wrote:
>>
>>> URL: http://svn.apache.org/viewvc?rev=1067734&view=rev
>>> Log:
>>> First attempt at a valve to limit session creation by web crawlers.
>>> Docs etc to follow once it is confirmed working.
>>>
>>> Added:
>>>
>>> tomcat/trunk/java/org/apache/catalina/valves/CrawlerSessionManagerValve.java
>>> (with props)
>
> Still trying to figure out why it doesn't work with Jira at the moment.
>
A pair of comments, if you will return to this code
Re: r1067759:
> String uaHeader = uaHeaders.nextElement();
If user-agent header is absent in the request it will fail.
I thought maybe refactor that user-agent header processing into a helper method,
protected boolean isBotRequest(Request request) { .. }
Re: r1067797
> request.addCookie(new Cookie("JSESSIONID",
Maybe request.setRequestedSessionCookie(true); call was needed as well.
Best regards,
Konstantin Kolinko
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
