https://issues.apache.org/bugzilla/show_bug.cgi?id=50651
--- Comment #7 from Filip Hanik <fha...@apache.org> 2011-01-26 14:20:26 EST --- (In reply to comment #6) > (In reply to comment #4) > Repeated calls to recycle() should succeed. Shouldn't they? Implementation of > InternalNioOutputBuffer.recycle() was already broken in this sense earlier, > since r428884. not really, calling recycle multiple times is probably just a sign of bad code. Whether the recycle method should be idempotent is a separate discussion. I agree that it should, but it doesn't mean it should be called multiple times. Cause the bugs that come up from coding like that, is way harder to track down. > > What is different in 6.0.30 is that several new calls to recycle() appeared -- > I remember of the one in [1], and thus this issue became apparent. The > reproduction recipe in comment 2 is based on [1]. > > [1] > http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java?r1=1030188&r2=1030187&pathrev=1030188 So, why not fix the real problem ? -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
