https://issues.apache.org/bugzilla/show_bug.cgi?id=50648

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #1 from Mark Thomas <ma...@apache.org> 2011-01-26 11:53:45 EST ---
(In reply to comment #0)
> This enhancement proposal addresses three separate issues with the RpcChannel
> tribes component.

Separate issues should have separate Bugzilla entries and separate patches.
Trying to manage multiple issues with a single Bugzilla entry quickly gets to
be a pain.

> 1. There is a minor bug in a catch(InterruptedException) clause, in which a
> call to Thread#interrupted() is made, as opposed to Thread#interrupt(), as it
> should be.

Fixed in 7.0.x and will be included in 7.0.7 onwards.


> 2. The RpcChannel API user registers an RpcCallback to be notified of
> communication events. However, there is no callback method for the case where
> the sending of a response message fails. This proposal includes the addition 
> of
> a corresponding callback for such cases. To ensure backwards-compatibility, 
> the
> additional callback method has been declared in a sub-interface of 
> RpcCallback,
> named RpcCallback2 for the time being.

Please open a new issue for this enhancement.
The API isn't fixed for 7.0.x so just add the method to the RpcCallback
interface. 
Patches should be the minimum to address the issue and should use the same
style as the existing code.

> 3. Since the tribes classes are loaded by the tomcat loader, if the messages
> sent through tribes are instances of classes defined in the webapp, attemps to
> deserialize them will fail. AbstractReplicatedMap includes a mechanism for the
> API user to specify class loaders to be used when deserializing map entries.
> This enhancement proposal includes a similar mechanism for the RpcChannel.

Please open a new issue for this enhancement request.
Patches should be the minimum to address the issue and should use the same
style as the existing code.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to