On 24/01/2011 10:00, Henri Gomez wrote: > Hi to all, > > I take a look at RemoteIpValve and wonder if they are plan to handle > also x-forwarded-host, x-forwarded-port and x-forwarded-proto ? > > The idea will be to use them to replace > getLocalName/getLocalPort/getScheme by x-forwarded-host, > x-forwarded-port and x-forwarded-proto.
x-forwarded-proto is already handled. x-forwarded-host is non-trivial since the mapping is done before the valve is invoked. Simpler to do the equivalent of ProxyPreserveHost On in the proxy. x-forwarded-port is not handled directly but x-forwarded-proto does set the port based on the protocol. > The fix should be easy and I could even provide the required patch. I'm not so sure it is that easy. > Go / NoGo ? Given the complexities, I'd need to see a clearer proposal or a patch to comment further. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
