Author: kkolinko
Date: Thu Jan 20 20:25:55 2011
New Revision: 1061495

URL: http://svn.apache.org/viewvc?rev=1061495&view=rev
Log:
patch was updated and is ok now. vote

Modified:
    tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1061495&r1=1061494&r2=1061495&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Thu Jan 20 20:25:55 2011
@@ -110,16 +110,8 @@ PATCHES PROPOSED TO BACKPORT:
 
 * Add helper class to allow a shared data source with different credentials
   http://people.apache.org/~fhanik/dslink.patch
-  +1: fhanik, funkman
+  +1: fhanik, funkman, kkolinko
   -1:
-   kkolinko:
-    1) Need to remove @Override at 
DataSourceLinkFactory.DataSourceHandler#invoke().
-    Otherwise it does not compile with Java 5. That is because 
InvocationHandler is an interface.
-    2) The following line in NamingContextListener#addResourceLink():
-    Iterator<String> i = resourceLink.listProperties();
-    Here ContextResourceLink#listProperties() returns Iterator, not
-    Iterator<String>, but IDE does not give me a warning and I see no
-    @SuppressWarnings arround. It is odd.
 
 * Fix very large memory leak in NIO connector
   Additional patch (not important):



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to