Author: markt
Date: Wed Jan 19 11:39:06 2011
New Revision: 1060772
URL: http://svn.apache.org/viewvc?rev=1060772&view=rev
Log:
Findbugs
Modified:
tomcat/trunk/res/findbugs/filter-post-7.0.x-fixes.xml
tomcat/trunk/webapps/examples/WEB-INF/classes/async/Stockticker.java
Modified: tomcat/trunk/res/findbugs/filter-post-7.0.x-fixes.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/res/findbugs/filter-post-7.0.x-fixes.xml?rev=1060772&r1=1060771&r2=1060772&view=diff
==============================================================================
--- tomcat/trunk/res/findbugs/filter-post-7.0.x-fixes.xml (original)
+++ tomcat/trunk/res/findbugs/filter-post-7.0.x-fixes.xml Wed Jan 19 11:39:06
2011
@@ -38,10 +38,18 @@
<Method name="writeObject" />
<Bug code="Se" />
</Match>
- <!-- Refactor Integer constants to an enum -->
+ <!-- Re-factor Integer constants to an enum -->
<Match>
<Class name="org.apache.catalina.startup.ClassLoaderFactory" />
<Method name="createClassLoader" />
<Bug code="RC" />
</Match>
+ <!-- Re-factor to only have the thread running when an instance of the
-->
+ <!-- handler is active -->
+ <Match>
+ <Class name="org.apache.juli.AsyncFileHandler$LoggerThread"/>
+ <Method name="run"/>
+ <Bug code="IL"/>
+ </Match>
+
</FindBugsFilter>
\ No newline at end of file
Modified: tomcat/trunk/webapps/examples/WEB-INF/classes/async/Stockticker.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/webapps/examples/WEB-INF/classes/async/Stockticker.java?rev=1060772&r1=1060771&r2=1060772&view=diff
==============================================================================
--- tomcat/trunk/webapps/examples/WEB-INF/classes/async/Stockticker.java
(original)
+++ tomcat/trunk/webapps/examples/WEB-INF/classes/async/Stockticker.java Wed
Jan 19 11:39:06 2011
@@ -99,7 +99,7 @@ public class Stockticker implements Runn
public void tick(Stock stock);
}
- public static class Stock {
+ public static final class Stock implements Cloneable {
protected static DecimalFormat df = new DecimalFormat("0.00");
protected String symbol = "";
protected double value = 0.0d;
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
