On 14/01/2011 07:45, Konstantin Kolinko wrote: > 2011/1/13 <ma...@apache.org>: >> Author: markt >> Date: Thu Jan 13 13:54:08 2011 >> New Revision: 1058556 >> >> URL: http://svn.apache.org/viewvc?rev=1058556&view=rev >> Log: >> Fix FindBugs warning >> Remove unnecessary code >> Better error handling >> >> Modified: >> tomcat/trunk/java/org/apache/catalina/ha/deploy/FarmWarDeployer.java >> > > >> @@ -244,7 +241,11 @@ public class FarmWarDeployer extends Clu >> addServiced(path); >> try { >> remove(path); >> - factory.getFile().renameTo(deployable); >> + if >> (!factory.getFile().renameTo(deployable)) { >> + log.error("Failed to rename [" + >> + factory.getFile() + "] to [" + >> + deployable + "]"); > (..) > > i18n ? > It is "error". It will be visible.
I was keeping my changes consistent with the rest of the file - no i18n is used for the other error messages. I agree that is not ideal. I'll add going through that file to my to do list. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
