JspFactory is in package javax.servlet.jsp which is one of the packages that has * import. If a user tried to create a class called JspFactory and tried to import it - he'd get a compile error on his import statement.

-Tim

On 1/12/2011 10:04 AM, Mark Thomas wrote:
On 12/01/2011 14:51, Tim Funk wrote:
I don't understand what this change other than provide noise. It doesn't
fix anything.

It protects against a user importing org.foo.JspFactory in their JSP
and breaking JSP compilation.

Granted it is unlikely, but the JSP spec doesn't prevent a user from
doing that (however stupid you or I may think such a class name is).

Mark



-Tim

On 1/12/2011 7:08 AM, ma...@apache.org wrote:
Author: markt
Date: Wed Jan 12 12:08:16 2011
New Revision: 1058102

URL: http://svn.apache.org/viewvc?rev=1058102&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=15688
Use fully qualified class names to avoid possible naming conflicts
JSP 2.2 TCK passes with these changes

Modified:
      tomcat/trunk/java/org/apache/jasper/compiler/Generator.java
      tomcat/trunk/java/org/apache/jasper/compiler/JspUtil.java
      tomcat/trunk/webapps/docs/changelog.xml


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org




---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to