On 15 December 2010 13:53, <ma...@apache.org> wrote:
> Author: markt
> Date: Wed Dec 15 13:53:22 2010
> New Revision: 1049553
>
> URL: http://svn.apache.org/viewvc?rev=1049553&view=rev
> Log:
> Fix another FindBugs niggle
>
> Modified:
>
> tomcat/trunk/webapps/examples/WEB-INF/classes/jsp2/examples/simpletag/ShuffleSimpleTag.java
>
> Modified:
> tomcat/trunk/webapps/examples/WEB-INF/classes/jsp2/examples/simpletag/ShuffleSimpleTag.java
> URL:
> http://svn.apache.org/viewvc/tomcat/trunk/webapps/examples/WEB-INF/classes/jsp2/examples/simpletag/ShuffleSimpleTag.java?rev=1049553&r1=1049552&r2=1049553&view=diff
> ==============================================================================
> ---
> tomcat/trunk/webapps/examples/WEB-INF/classes/jsp2/examples/simpletag/ShuffleSimpleTag.java
> (original)
> +++
> tomcat/trunk/webapps/examples/WEB-INF/classes/jsp2/examples/simpletag/ShuffleSimpleTag.java
> Wed Dec 15 13:53:22 2010
> @@ -19,6 +19,7 @@
> package jsp2.examples.simpletag;
>
> import java.io.IOException;
> +import java.util.Random;
>
> import javax.servlet.jsp.JspException;
> import javax.servlet.jsp.tagext.JspFragment;
> @@ -29,13 +30,16 @@ import javax.servlet.jsp.tagext.SimpleTa
> * JspFragment and invokes then in a random order.
> */
> public class ShuffleSimpleTag extends SimpleTagSupport {
> + // No need for this to use SecureRandom
But the field should surely be final?
> + private static Random random = new Random();
> +
> private JspFragment fragment1;
> private JspFragment fragment2;
> private JspFragment fragment3;
>
> @Override
> public void doTag() throws JspException, IOException {
> - switch( (int)(Math.random() * 6) ) {
> + switch(random.nextInt(6)) {
> case 0:
> fragment1.invoke( null );
> fragment2.invoke( null );
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
