On 7 October 2010 22:53,  <ma...@apache.org> wrote:
> Author: markt
> Date: Thu Oct  7 21:53:55 2010
> New Revision: 1005647
>
> URL: http://svn.apache.org/viewvc?rev=1005647&view=rev
> Log:
> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49987
> Fix thread safety issue with population of servlet context initialization 
> parameters.
>
> Modified:
>    tomcat/trunk/java/org/apache/catalina/core/ApplicationContext.java
>    tomcat/trunk/java/org/apache/catalina/core/StandardContext.java
>    tomcat/trunk/webapps/docs/changelog.xml
>
> Modified: tomcat/trunk/java/org/apache/catalina/core/ApplicationContext.java
> URL: 
> http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/ApplicationContext.java?rev=1005647&r1=1005646&r2=1005647&view=diff
> ==============================================================================
> --- tomcat/trunk/java/org/apache/catalina/core/ApplicationContext.java 
> (original)
> +++ tomcat/trunk/java/org/apache/catalina/core/ApplicationContext.java Thu 
> Oct  7 21:53:55 2010
> @@ -66,7 +66,6 @@ import org.apache.catalina.LifecycleStat
>  import org.apache.catalina.Service;
>  import org.apache.catalina.Wrapper;
>  import org.apache.catalina.connector.Connector;
> -import org.apache.catalina.deploy.ApplicationParameter;
>  import org.apache.catalina.deploy.FilterDef;
>  import org.apache.catalina.util.Enumerator;
>  import org.apache.catalina.util.RequestUtil;
> @@ -173,7 +172,8 @@ public class ApplicationContext
>     /**
>      * The merged context initialization parameters for this Context.
>      */
> -    private Map<String,String> parameters = null;
> +    private Map<String,String> parameters =
> +        new ConcurrentHashMap<String,String>();
>

Could/Should be final to ensure safe publication...

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to