svn commit: r998168 - in /tomcat/trunk/java/org/apache/coyote/http11: Http11AprProcessor.java InternalNioInputBuffer.java InternalNioOutputBuffer.java

[markt]

Author: markt
Date: Fri Sep 17 15:02:45 2010
New Revision: 998168

URL: http://svn.apache.org/viewvc?rev=998168&view=rev
Log:
Misc Eclipse and FindBugs warnings

Modified:
    tomcat/trunk/java/org/apache/coyote/http11/Http11AprProcessor.java
    tomcat/trunk/java/org/apache/coyote/http11/InternalNioInputBuffer.java
    tomcat/trunk/java/org/apache/coyote/http11/InternalNioOutputBuffer.java

Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11AprProcessor.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/Http11AprProcessor.java?rev=998168&r1=998167&r2=998168&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/coyote/http11/Http11AprProcessor.java 
(original)
+++ tomcat/trunk/java/org/apache/coyote/http11/Http11AprProcessor.java Fri Sep 
17 15:02:45 2010
@@ -534,7 +534,8 @@ public class Http11AprProcessor extends 
                         request.setAttribute(AbstractEndpoint.CERTIFICATE_KEY, 
certs);
                     }
                     // User key size
-                    sslO = new Integer(SSLSocket.getInfoI(socket, 
SSL.SSL_INFO_CIPHER_USEKEYSIZE));
+                    sslO = Integer.valueOf(SSLSocket.getInfoI(socket,
+                            SSL.SSL_INFO_CIPHER_USEKEYSIZE));
                     request.setAttribute(AbstractEndpoint.KEY_SIZE_KEY, sslO);
 
                     // SSL session ID

Modified: tomcat/trunk/java/org/apache/coyote/http11/InternalNioInputBuffer.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/InternalNioInputBuffer.java?rev=998168&r1=998167&r2=998168&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/coyote/http11/InternalNioInputBuffer.java 
(original)
+++ tomcat/trunk/java/org/apache/coyote/http11/InternalNioInputBuffer.java Fri 
Sep 17 15:02:45 2010
@@ -378,7 +378,6 @@ public class InternalNioInputBuffer exte
             byte[] tmp = new byte[newsize];
             System.arraycopy(buf,0,tmp,0,buf.length);
             buf = tmp;
-            tmp = null;
         }
     }
     

Modified: 
tomcat/trunk/java/org/apache/coyote/http11/InternalNioOutputBuffer.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/InternalNioOutputBuffer.java?rev=998168&r1=998167&r2=998168&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/coyote/http11/InternalNioOutputBuffer.java 
(original)
+++ tomcat/trunk/java/org/apache/coyote/http11/InternalNioOutputBuffer.java Fri 
Sep 17 15:02:45 2010
@@ -44,9 +44,6 @@ public class InternalNioOutputBuffer ext
 
 
     // ----------------------------------------------------------- Constructors
-    int bbufLimit = 0;
-    
-    
     /**
      * Default constructor.
      */
@@ -65,13 +62,6 @@ public class InternalNioOutputBuffer ext
 
         buf = new byte[headerBufferSize];
         
-        if (headerBufferSize < (8 * 1024)) {
-            bbufLimit = 6 * 1500;    
-        } else {
-            bbufLimit = (headerBufferSize / 1500 + 1) * 1500;
-        }
-        //bbuf = ByteBuffer.allocateDirect(bbufLimit);
-
         outputStreamOutputBuffer = new SocketOutputBuffer();
 
         filterLibrary = new OutputFilter[0];



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org