Author: kkolinko
Date: Sun Aug 29 23:34:35 2010
New Revision: 990673

URL: http://svn.apache.org/viewvc?rev=990673&view=rev
Log:
comment and vote

Modified:
    tomcat/tc5.5.x/trunk/STATUS.txt

Modified: tomcat/tc5.5.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev=990673&r1=990672&r2=990673&view=diff
==============================================================================
--- tomcat/tc5.5.x/trunk/STATUS.txt (original)
+++ tomcat/tc5.5.x/trunk/STATUS.txt Sun Aug 29 23:34:35 2010
@@ -59,10 +59,14 @@ PATCHES PROPOSED TO BACKPORT:
   -1:
   -0: rjung
   rjung: Should we really change default behaviour for a mature version?
+  kkolinko: (I think that hardly anyone uses that feature, and if it is needed,
+  one can reenable it now by setting the maxPort attribute.
+  It is possible to make this configurable without changing the default
+  -- see attachment 25657 in BZ 49521, but I do not think that it is worth it.)
 
 * Add Null check when CHANGE_SESSION_ID message received.
   http://svn.apache.org/viewvc?rev=982877&view=rev
-  +1: kfujino, markt, rjung
+  +1: kfujino, markt, rjung, kkolinko
   -1: 
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49749
@@ -70,12 +74,23 @@ PATCHES PROPOSED TO BACKPORT:
   http://people.apache.org/~markt/patches/2010-08-25-bug49749.patch
   +1: markt, rjung
   -1:
+  +1: kkolinko: Looking for usages of Constants.SINGLE_SIGN_ON_COOKIE,
+     in SingleSignOn.invoke() there is one more call to response.addCookie().
+     It is used to remove the cookie, so I think HttpOnly is not important 
there
+     and thus I am letting this pass. The SingleSignOn valve is usually added 
to
+     a <Host> (looking at the default server.xml), so we have to call
+     request.getContext() to get a Context there?
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=38113
   Add system property to allow spec compliant handling of query string
   http://people.apache.org/~markt/patches/2010-08-25-bug38113.patch
   +1: markt, rjung
   -1:
+  +1: kkolinko: (only with the following trivial change:
+     s/Boolean.parseBoolean(..)/Boolean.valueOf(..).booleanValue()/
+     because parseBoolean is @since 1.5.
+     See Globals.java line 334 for an example.
+  )
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49774
   Add SSL support using the APR connector to the admin app



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to