Author: markt
Date: Thu Jul 15 21:37:41 2010
New Revision: 964614

URL: http://svn.apache.org/viewvc?rev=964614&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49598
When updating the session cookie header, actually update it rather than adding 
a new header without a name.

Modified:
    tomcat/trunk/java/org/apache/catalina/connector/Response.java
    tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/java/org/apache/catalina/connector/Response.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/Response.java?rev=964614&r1=964613&r2=964614&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/connector/Response.java (original)
+++ tomcat/trunk/java/org/apache/catalina/connector/Response.java Thu Jul 15 
21:37:41 2010
@@ -974,7 +974,7 @@ public class Response
         for (int i = 0; i < n; i++) {
             if (headers.getName(i).toString().equals(headername)) {
                 if (headers.getValue(i).toString().startsWith(startsWith)) {
-                    headers.setValue(sb.toString());
+                    headers.getValue(i).setString(sb.toString());
                     set = true;
                 }
             }

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=964614&r1=964613&r2=964614&view=diff
==============================================================================
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Thu Jul 15 21:37:41 2010
@@ -162,6 +162,11 @@
         Avoid NullPointerException, when copyXML=true and META-INF/context.xml 
         does not exist. (kfujino)
       </fix>
+      <fix>
+        <bug>49598</bug>: When session is changed and the session cookie is
+        replaced, ensure that the new Set-Cookie header overwrites the old
+        Set-Cookie header. (markt) 
+      </fix>
     </changelog>
   </subsection>
   <subsection name="Jasper">



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to