https://issues.apache.org/bugzilla/show_bug.cgi?id=49395
sylvain.laur...@gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25535|0 |1 is obsolete| | Attachment #25536|0 |1 is obsolete| | --- Comment #6 from sylvain.laur...@gmail.com 2010-06-09 17:02:11 EDT --- Created an attachment (id=25570) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25570) patch for tomcat 7, v2 I'm proposing a new patch that addresses the points you noticed. There remains the question of JMX > 1) Host.findReloadedContextMemoryLeaks is callable through JMX. > I need to test it, but I suppose that ContextLeakInfo cannot be rendered by > JConsole. In the new patch I kept the String[] for the return value, separating context path, start date and stop dates by a tab. > > 2) It looks like an API change for me. If we keep String[], the only thing that change is the content of the Strings. Is it that important ? This type of information is probably rather for humans. > > 3) I would like to see not only when the context was started, but also when it > was stopped. done > 4) ContextLeakInfo.java needs the Apache license header. done > 5) i18n. I just modified the text in the HTMLmanager translation. Dates are is ISO 8601 format, no need for translation. > 6) As a further enhancement I think that the result returned by > StandardHost.findReloadedContextMemoryLeaks() might be sorted by contextPath > and then by startDate. done > 7) The documentation has to be updated: manager-howto.xml, > html-manager-howto.xml done -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org