On 08.06.2010 22:08, William A. Rowe Jr. wrote:
On 6/8/2010 1:19 PM, William A. Rowe Jr. wrote:
-1 veto. This is not the appropriate test for a threaded MPM.
We have ap_mpm_query for this very purpose, please don't continue
to propagate this broken meme!!!
I'm sorry - I didn't read this patch sufficiently (zeroed straight
into the APR_HAVE_THREADS test). However, there seems to be no reason
to exclude logging the threads with static builds(!?!)
I'm not sure there's any reason to test AP_MPMQ_NOT_SUPPORTED either;
this should be a true/false since this query was introduced day one.
Actually the OS2 and Netware MPMs return AP_MPMQ_DYNAMIC for that query.
Although I never worked with those MPMs, the code indicates they are
actually threaded, but the number of threads per process can vary.
So checking against AP_MPMQ_NOT_SUPPORTED is safer.
Rainer
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
