On 07/06/2010 05:11, Konstantin Kolinko wrote: > 2010/6/7 <ma...@apache.org>: >> Author: markt >> Date: Sun Jun 6 21:50:11 2010 >> New Revision: 952000 >> >> URL: http://svn.apache.org/viewvc?rev=952000&view=rev >> Log: >> Make syncs consistent >> Partial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=49372 >> Avoid invalid Lifecycle transitions on failed start due to already bound >> shutdown port >> >> Modified: >> tomcat/trunk/java/org/apache/catalina/util/LifecycleBase.java >> > >> +++ tomcat/trunk/java/org/apache/catalina/util/LifecycleBase.java Sun Jun 6 >> 21:50:11 2010 >> @@ -134,7 +134,12 @@ public abstract class LifecycleBase impl >> >> setState(LifecycleState.STARTING_PREP); >> >> - startInternal(); >> + try { >> + startInternal(); >> + } catch (LifecycleException e) { >> + setState(LifecycleState.FAILED); >> + throw e; >> + } >> >> if (state.equals(LifecycleState.FAILED) || >> state.equals(LifecycleState.MUST_STOP)) { > > Probably RuntimeException and Error should also move it into the > FAILED state?
Maybe. RuntimeException probbaly indicates a bug elsewhere rather than user error so I'm less concerned about graceful handling. With an Error I suspect the odds of handling anything gracefully are pretty low. trunk is still CTR so there is nothing stopping you making the change. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
