Author: kkolinko
Date: Mon May 24 11:01:59 2010
New Revision: 947598

URL: http://svn.apache.org/viewvc?rev=947598&view=rev
Log:
vote

Modified:
    tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=947598&r1=947597&r2=947598&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Mon May 24 11:01:59 2010
@@ -60,8 +60,13 @@ PATCHES PROPOSED TO BACKPORT:
 
 * Make user's role list immutable. Modify a copy in getRoles(DirContext, User)
   http://svn.apache.org/viewvc?rev=945841&view=rev
-  +1: markt, rjung
+  +1: markt, rjung, kkolinko
   -1: 
+    kkolinko: There is one caveat with Collections.unmodifiableList(): the
+    original list is still owned and modifieable by whoever created it,
+    i.e. by the caller of User class constructor. Though with the current
+    code of JNDIRealm that does not manifest itself and can be left as an
+    API comment.
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48701
   Take account of TagVariableInfo when implementing the rules of JSP.5.3



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to