On 21/05/2010, Mark Thomas <ma...@apache.org> wrote: > We found a few issues in RC2 so I'm going to create RC3. Before I do, > are there any other issues in RC2 that need fixing? If no-one speaks up > I'll roll RC3 over the weekend.
I'm not sure how serious these are: There are a lot of Javadoc complaints for the javax packages - mainly missing @return text. Several catalina/authenticator subclasses define fields which hide the super-class field. In some cases I think this is caused by the superclass field being protected rather than private. It looks as though the info fields should be private throughout, as they seem to be class-specific. It's less obvious what to do with the sm fields - some lines of code can be saved by using protected, but if the subclass fails to override it when it should then problems may occur. Either keep the definition in ValveBase protected, and remove all the sub-class "redefinitions" (which don't actually change anything, AFAICT), or use private vars throughout. The field valves.ValveBase.info should be final. > Mark > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
