Author: kkolinko
Date: Sat May 15 22:11:09 2010
New Revision: 944732
URL: http://svn.apache.org/viewvc?rev=944732&view=rev
Log:
revoke my vote thanks to Rainer, add comments
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=944732&r1=944731&r2=944732&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Sat May 15 22:11:09 2010
@@ -133,8 +133,8 @@ PATCHES PROPOSED TO BACKPORT:
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48379
Make session cookie name, domain and path configurable per context.
http://people.apache.org/~markt/patches/2010-05-05-bug48379.patch
- +1: markt, kkolinko, rjung
- -1:
+ +1: markt, rjung
+ -1: kkolinko
kkolinko: (Trivial:
in JvmRouteBinderValve#setNewSessionCookie()
in if (log.isDebugEnabled()) { ... } block
@@ -148,7 +148,16 @@ PATCHES PROPOSED TO BACKPORT:
be null or not. I propose adding
http://svn.apache.org/viewvc?rev=944511&view=rev
+1: rjung
- -1:
+ -1: kkolinko: I agree with the above comment, but not the patch:
+ I'd be better to move the scName (or name it 'sessionCookieName')
+ outside the loop.
+
+ kkolinko: It would be better if context.getSessionCookieName() returned
+ the same value (null) by default both in 6.0 and 7.0, so that the API were
the same.
+ We can backport ApplicationSessionCookieConfig.getSessionCookieName()
+ method from TC7.
+
+ kkolinko: "context." vs "getContext()." used inconsistently in
Request.java#configureSessionCookie
rjung: In Request.configureSessionCookie(): should there be a check
for context != null before calling context.getSessionCookieDomain()?
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
