2010/4/29 Peter Roßbach <p...@objektpark.de>:
> OK, I change my default.
>
> A lot of tomcat classes has this problem. I found 861 java files at tomcat 7
> with token "Revision"!
>

$Revision$ keyword is OK. It is $Date$ that is faulty, because it
 a) uses i18n for the month and day of week names,
 b) uses local timezone.

I replaced all occurrences of $Date$ keyword with $Id$ in trunk.

I'll do the same in 6.0 and 5.5 as well.


> I found 861 java files at tomcat 7

There were about 400 files with $Date$ in trunk.


Best regards,
Konstantin Kolinko


> Peter
>
> Am 29.04.2010 um 09:30 schrieb kkoli...@apache.org:
>
>> Author: kkolinko
>> Date: Thu Apr 29 07:30:29 2010
>> New Revision: 939221
>>
>> URL: http://svn.apache.org/viewvc?rev=939221&view=rev
>> Log:
>> $Date$ was wrapped and thus broken in r939212
>>
>> Replacing with $Id$ because of i18n and timezone issues that $Date$ has
>> (http://subversion.tigris.org/issues/show_bug.cgi?id=2332)
>>
>> Modified:
>>
>> tomcat/trunk/test/org/apache/catalina/startup/DuplicateMappingParamServlet.java
>>   tomcat/trunk/test/org/apache/catalina/startup/NoMappingParamServlet.java
>>   tomcat/trunk/test/org/apache/catalina/startup/ParamServlet.java
>>
>> tomcat/trunk/test/org/apache/catalina/startup/TestContextConfigAnnotation.java
>>
>> Modified:
>> tomcat/trunk/test/org/apache/catalina/startup/DuplicateMappingParamServlet.java
>> URL:
>> http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/startup/DuplicateMappingParamServlet.java?rev=939221&r1=939220&r2=939221&view=diff
>>
>> ==============================================================================
>> ---
>> tomcat/trunk/test/org/apache/catalina/startup/DuplicateMappingParamServlet.java
>> (original)
>> +++
>> tomcat/trunk/test/org/apache/catalina/startup/DuplicateMappingParamServlet.java
>> Thu Apr 29 07:30:29 2010
>> @@ -29,8 +29,7 @@ import javax.servlet.http.HttpServletRes
>> /**
>>  *
>>  * @author Peter Rossbach
>> - * @version $Revision$ $Date: 2010-04-29 00:16:49 +0200 (Thu, 29 Apr
>> - *          2010) $
>> + * @version $Id$
>>  */
>> @WebServlet(value = "/annotation/overwrite", urlPatterns = { "/param2" },
>> name = "param", initParams = {
>>       �...@webinitparam(name = "foo", value = "Hello"),
>>
>> Modified:
>> tomcat/trunk/test/org/apache/catalina/startup/NoMappingParamServlet.java
>> URL:
>> http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/startup/NoMappingParamServlet.java?rev=939221&r1=939220&r2=939221&view=diff
>>
>> ==============================================================================
>> ---
>> tomcat/trunk/test/org/apache/catalina/startup/NoMappingParamServlet.java
>> (original)
>> +++
>> tomcat/trunk/test/org/apache/catalina/startup/NoMappingParamServlet.java Thu
>> Apr 29 07:30:29 2010
>> @@ -29,8 +29,7 @@ import javax.servlet.http.HttpServletRes
>> /**
>>  *
>>  * @author Peter Rossbach
>> - * @version $Revision$ $Date: 2010-04-29 00:16:49 +0200 (Thu, 29 Apr
>> - *          2010) $
>> + * @version $Id$
>>  */
>> @WebServlet(name = "param1", initParams = {
>>       �...@webinitparam(name = "foo", value = "Hello"),
>>
>> Modified: tomcat/trunk/test/org/apache/catalina/startup/ParamServlet.java
>> URL:
>> http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/startup/ParamServlet.java?rev=939221&r1=939220&r2=939221&view=diff
>>
>> ==============================================================================
>> --- tomcat/trunk/test/org/apache/catalina/startup/ParamServlet.java
>> (original)
>> +++ tomcat/trunk/test/org/apache/catalina/startup/ParamServlet.java Thu
>> Apr 29 07:30:29 2010
>> @@ -29,8 +29,7 @@ import javax.servlet.http.HttpServletRes
>> /**
>>  *
>>  * @author Peter Rossbach
>> - * @version $Revision$ $Date: 2010-04-29 00:16:49 +0200 (Thu, 29 Apr
>> - *          2010) $
>> + * @version $Id$
>>  */
>> @WebServlet(value = "/annotation/overwrite", name = "param", initParams =
>> {
>>       �...@webinitparam(name = "foo", value = "Hello"),
>>
>> Modified:
>> tomcat/trunk/test/org/apache/catalina/startup/TestContextConfigAnnotation.java
>> URL:
>> http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/startup/TestContextConfigAnnotation.java?rev=939221&r1=939220&r2=939221&view=diff
>>
>> ==============================================================================
>> ---
>> tomcat/trunk/test/org/apache/catalina/startup/TestContextConfigAnnotation.java
>> (original)
>> +++
>> tomcat/trunk/test/org/apache/catalina/startup/TestContextConfigAnnotation.java
>> Thu Apr 29 07:30:29 2010
>> @@ -28,8 +28,7 @@ import org.apache.catalina.deploy.WebXml
>>  * fragment.
>>  *
>>  * @author Peter Rossbach
>> - * @version $Revision$ $Date: 2010-04-29 00:16:49 +0200 (Thu, 29 Apr
>> - *          2010) $
>> + * @version $Id$
>>  */
>> public class TestContextConfigAnnotation extends TestCase {
>>
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>> For additional commands, e-mail: dev-h...@tomcat.apache.org
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to