https://issues.apache.org/bugzilla/show_bug.cgi?id=49176

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|INVALID                     |
           Severity|minor                       |enhancement

--- Comment #4 from Mark Thomas <ma...@apache.org> 2010-04-23 19:37:10 EDT ---
Not having the page nodes after a restart is probably a separate issue
(although one worth keeping in mind whilst thinking about this issue).

Keep in mind that pageNode generation is expensive, relative to serving a
response. Not caching the pageNodes is likely to open up a DOS attack vector.

A theoretical (as in I haven't looked at the code to see if it is feasible or
how much work it would be) is to ignore the pageNodes and use the SMAP. The
SMAP could either be cached (should be much smaller than pageNodes) or read
when required. Since it is saved in the .class file it would also survive a
restart. I'd be tempted to cache it for the life of the JVM on compilation and
read it from disk as required after a restart.

I'm re-opening this and marking it as a (performance) enhancement.

It will get looked at eventually, but enhancements tend to be at the bottom of
people's todo list. If you wanted to provide a patch...

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to