Author: kkolinko
Date: Thu Apr 22 01:10:50 2010
New Revision: 936589
URL: http://svn.apache.org/viewvc?rev=936589&view=rev
Log:
veto and propose another patch
Modified:
tomcat/tc5.5.x/trunk/STATUS.txt
Modified: tomcat/tc5.5.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev=936589&r1=936588&r2=936589&view=diff
==============================================================================
--- tomcat/tc5.5.x/trunk/STATUS.txt (original)
+++ tomcat/tc5.5.x/trunk/STATUS.txt Thu Apr 22 01:10:50 2010
@@ -48,9 +48,24 @@ PATCHES PROPOSED TO BACKPORT:
Port of r439565, r832102 & r904834
http://people.apache.org/~markt/patches/2010-01-30-bug47878-tc5.patch
+1: markt
+ -1: kkolinko: (I think the patch to JspServletWrapper#service() method is
wrong.
+
+ One thing that surely is wrong there: when FileNotFoundException is
caught after
+ compile() we may respond with response.sendError(SC_NOT_FOUND).
+ This sendError() call should be followed by return, but instead we
+ fall down to execute theServlet.service() method.
+ Actually that sendError() is not needed, as we can just rethrow the FNFE:
+ our caller - JspServlet#serviceJspFile() - will catch it and report.
+
+ I propose a corrected patch below. I replaced the proposed changes to
+ JspServletWrapper#service() with the current code from 6.0.x.
+ )
+
+ Corrected patch based on Mark's one:
+ http://people.apache.org/~kkolinko/patches/2010-04-22_tc55_bug47878.patch
+ +1: kkolinko
-1:
- kkolinko - Just a note: This issue won't affect configurations where
Jasper
- runs with development=false.
+
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48179
Improve processing of TLD cache file
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
