https://issues.apache.org/bugzilla/show_bug.cgi?id=49140

           Summary: Inefficient use of keySet() iterator in
                    StandardContext.java
           Product: Tomcat 7
           Version: trunk
          Platform: PC
        OS/Version: Windows XP
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: Catalina
        AssignedTo: dev@tomcat.apache.org
        ReportedBy: s...@apache.org


Created an attachment (id=25316)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25316)
Change keySet() Iterator to values()

The loadOnStartup(Container[]) method of StandardContext loops on the keySet()
but actually only uses the key to get the values, so it would be more efficient
to use the values() Iterator.

According to the Javadoc, the keySet() and values() iterators generate the
entries in the same order (key ascending).

Findbugs detected another 6 such instances for which I can provide patches if
required.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to