On 14/04/2010 22:22, sebb wrote: > On 14/04/2010, Mark Thomas <ma...@apache.org> wrote: >> On 14/04/2010 21:06, sebb wrote: >> > Many of the java and xml files in tomcat-lite don't have AL headers. >> >> Not an issue. tomcat-lite isn't being shipped (at least it shoudln't be..) > > It's currently in the source archives. I've dropped modules from the src archive. They shouldn't have been included.
> Also, SVN is considered by some to be publishing code (e.g. links are > usually published on the web-site) so better safe than sorry. Then they are mis-informed. > Just noticed - RELEASE-NOTES in source archive contains: > > "Tomcat @VERSION_MAJOR_MINOR@ is designed to run on Java SE 6 and later. > > In addition, Tomcat @VERSION_MAJOR_MINOR@ uses the Eclipse JDT Java > compiler for" > > A few other source files also have similar tags (I searched for "@VERSION_"). > > I think the tags in the RELEASE-NOTES (and RUNNING.txt) ought to be > processed to correspond with the release. I disagree. The source bundle should be an exact copy of the tag. The version number is set in build.properties. > This is not so clear for some of the other files - are they supposed > to be the same as the SVN versions, or should they be customised for > the release? See previous comment. > Also, in the Windows binary archives, service.bat includes an RC1 reference: > set PR_DESCRIPTION=Apache Tomcat 7.0.0-RC1 Server - http://tomcat.apache.org/ > > As do various copies of Release Notes and index.html As intended. > I assume the other binary archives are similar, but I did not check them. > > I would have thought that these version references should omit the RC1 > suffix, unless the code is to be released as such (which has been > known in other projects). I disagree. I want to be quite clear which version someone is using when they report a bug, particularly with release candidates when there are likely to be several versions close together. When we have an RC we are happy with, a new tag for the final release will be created and voted on that does not include the RCn. That vote should be very quick as all that will be required is comparing the RCn source tarball with the release source tarball. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
