https://issues.apache.org/bugzilla/show_bug.cgi?id=49045

chamith buddhika <chamibuddh...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #25228|0                           |1
        is obsolete|                            |

--- Comment #7 from chamith buddhika <chamibuddh...@gmail.com> 2010-04-13 
07:32:51 EDT ---
Created an attachment (id=25277)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25277)
Adding createStandardService method to MBeanFactory

Sorry for the delay. I was busy summing up some other work. I have been looking
more in to the issue of MBeanFactory.The issue was caused by the fact that
MBeanFactory itself being a BaseModelBean unlike other normal classes such as
StandardService etc. Although it extends BaseModelBean it doesn't utilise any
of its inherited methods and it being a BaseModelBean is not leveraged in any
other point in the sources. So I suggest removing 'is a' relationship between
MBeanFactory and BaseModelBean and make MBeanFactory a normal class which can
be managed using a BaseModelBean object. It solves the issue that both managed
resource and the mbean being instances of the same class, a situation which is
unique to MBeanFactory.

In this patch I have reversed the changes made to the modeler code in order to
overcome the earlier issue. And additionally separate create method has been
added to create an Engine component.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to