On 10/04/2010, kkoli...@apache.org <kkoli...@apache.org> wrote: > Author: kkolinko > Date: Sat Apr 10 13:44:05 2010 > New Revision: 932717 > > URL: http://svn.apache.org/viewvc?rev=932717&view=rev > Log: > change my vote > > Modified: > tomcat/tc5.5.x/trunk/STATUS.txt > > Modified: tomcat/tc5.5.x/trunk/STATUS.txt > URL: > http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev=932717&r1=932716&r2=932717&view=diff > > ============================================================================== > --- tomcat/tc5.5.x/trunk/STATUS.txt (original) > +++ tomcat/tc5.5.x/trunk/STATUS.txt Sat Apr 10 13:44:05 2010 > @@ -29,9 +29,11 @@ PATCHES PROPOSED TO BACKPORT: > Warn if the user tries to set an invalid property. > Port of http://svn.apache.org/viewvc?view=rev&revision=565464 > http://people.apache.org/~markt/patches/2009-07-02-bug38743.patch > - +1: markt, kkolinko > + +1: markt > 0: fhanik - big step for an old branch, could be risky, I'd wait until > after next release if we consider it > - -1: > + -1: kkolinko: It is reported that the change to the return type of the > setProperty > + method in o.a.t.util.IntrospectionUtils breaks binary compatibility: > + http://marc.info/?l=tomcat-user&m=127083540720353&w=2
This is the sort of API change that would be detected by Clirr. Might be worth considering doing a Clirr report as part of release candidate checking? However, Clirr does not know which public methods are part of the external API and which are only required to be internally consistent, so it may generate too many false positives. > * Minor cleanups for AccessLogValve classes > Reuses StringBuffer, uses char instead of single-char String, etc. > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
