https://issues.apache.org/bugzilla/show_bug.cgi?id=48903

--- Comment #6 from Konstantin Kolinko <knst.koli...@gmail.com> 2010-03-25 
19:57:49 UTC ---
Created an attachment (id=25185)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25185)
2010-03-15_tc6_bug48903_v2.patch

Patch for the current tc6.0.x (as of rev.922264) that fixes this issue *and*
introduces a new system property and helper class to make use of the new JRE 7
feature of parallel classloading.


Known issues with this patch, found during review
(should be fixed before applying it):
-----------------------------------------------------
1. "JasperLoader extends LockAwareURLClassLoader":
It creates a dependency between Jasper and Catalina. Jasper should be
independent.

Maybe move the class into o.a.tomcat.util.<something>.*

May consider to rename the package part of the "CLASSLOADER_LOCK_POLICY" system
property as well.


2. Use the StringManager for i18n.

Though as far as I see all those are debug messages, so i18n may be not
necessary there.

3. o.a.catalina.loader.StandardClassLoader should also inherit from
LockAwareURLClassLoader and call "registerAsParallelCapable", like JasperLoader
does.

It means that LockAwareURLClassLoader class should be included into
bootstrap.jar and removed from other Tomcat jars.

Thus, some changes to the build.xml file are also necessary.


4. I have doubt that support for the "name" as value of CLASSLOADER_LOCK_POLICY
is needed. Even if it works with recent JRE 6 with some (undocumented) options,
I will not recommend it for production. Is anybody there who needs that
feature?

5. JRE 7 is not released yet, so something can still be changing there.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to