On 05/03/2010 13:50, Konstantin Kolinko wrote:
> 2010/3/5  <ma...@apache.org>:
>> Author: markt
>> Date: Fri Mar  5 09:38:52 2010
>> New Revision: 919349
>>
>> URL: http://svn.apache.org/viewvc?rev=919349&view=rev
>> Log:
>> Vote
>>
> 
>>  * Improve logging behaviour when shutdown occurs via a shutdownhook. If 
>> present,
>> @@ -118,6 +118,7 @@
>>   (revisions 910974,918594,918792,918799,918787,918885):
>>   http://people.apache.org/~kkolinko/patches/2010-03-04_tc6_bug48831.patch
>>   +1: kkolinko
>> +  +1: markt with http://svn.apache.org/viewvc?rev=919347&view=rev
> 
> Re: 919347 ("Ensure read lock is obtained before write lock is
> released on an error condition")
> Mark,
> on error condition we should release all locks and quit the method
> (there is only one lock there: write lock).
> We should not obtain the read lock after an error in that try{} block.
Yep - not enough caffine for me this morning. I'll revert.

Mark



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to