On 03/03/2010 11:10, Konstantin Kolinko wrote: > 2010/3/2 <ma...@apache.org>: >> Author: markt >> Date: Tue Mar 2 16:02:25 2010 >> New Revision: 918093 >> >> URL: http://svn.apache.org/viewvc?rev=918093&view=rev >> Log: >> Better fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48660 >> As per Konstantin's comments, ensure a single Vary header is used and take >> account of * if present >> >> Modified: >> tomcat/trunk/java/org/apache/coyote/http11/Http11AprProcessor.java >> tomcat/trunk/java/org/apache/coyote/http11/Http11NioProcessor.java >> tomcat/trunk/java/org/apache/coyote/http11/Http11Processor.java >> > > >> + MessageBytes vary = headers.getValue("Vary"); >> + if (vary == null) { >> + // Add a new Vary header >> + headers.setValue("Vary").setString("Accept-Encoding"); >> + } else if (vary.equals("*")) { > The above is MessageBytes.equals(String). I am sure that it won't work > as expected.
I know. It was deliberate. I'm equally sure it will work as expected. Did you look at the implementation of the MessageBytes#equals(String) method? Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
